-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[test] Run snapshot tests on the a11y tree #20019
Conversation
No bundle size changes comparing 440a68f...789ef79 |
on: status | ||
jobs: | ||
build: | ||
if: github.event.state == 'success' && github.event.sender.login == 'netlify[bot]' && github.event.description == 'Deploy preview ready!' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Communication is working: https://github.com/eps1lon/mui-scripts-incubator/actions/runs/51451071 We just need to move the trigger so that the message is sent after a successful deploy not right after the push. Need to push this to master in order to get a workflow run on |
The actual logic is done in https://github.com/eps1lon/mui-scripts-incubator/tree/master/lib/a11y-snapshot.
It saves a snapshot of the a11y tree for https://material-ui.netlify.com/ and https://material-ui.netlify.com/components/select and checks these against new pushes on master as well as PRs.
example snapshot
Since it's not clear how useful that information is I moved the logic into a separate behavior. This means that the PR workflow in this repository is unaffected. We don't want to burden contributors with experimental workflows and false alarms (see argos and test_browser).